[generator] Add [SupportedOSPlatform] attributes to bound constant fields.#1038
Merged
[generator] Add [SupportedOSPlatform] attributes to bound constant fields.#1038
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #1037
Currently we do not add
[SupportedOSPlatform]attributes to boundconstfields, which can lead to users using them on platforms where they are not supported:This commit fixes this:
Note this does not address the
enumpart of #1037, which will require a much more involved fix.